Skip to content

fix(ui): preserve sequential gradient sample order #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minwookshin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): preserve sequential gradient sample order #296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions docs/ui/src/js/initialSequentialScale.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ governing permissions and limitations under the License.
*/

import * as Leo from '@adobe/leonardo-contrast-colors';
import {convertColorValue, makePowScale, round, findMatchingLuminosity, orderColorsByLuminosity} from './utils';
import {convertColorValue, makePowScale, round, findMatchingLuminosity} from './utils';
import chroma from 'chroma-js';
import {extendChroma} from './chroma-plus';

Expand All @@ -32,10 +32,10 @@ class SequentialScale {

set colorKeys(colors) {
this._colorKeys = colors;
this._luminosities = this._getLuminosities();
this._colors = null;
this._colorsReversed = null;
this._colors = this._createColorScale();
this._luminosities = this._getLuminosities();
this._domains = this._getDomains();
}

Expand Down Expand Up @@ -217,10 +217,10 @@ class SequentialScale {
let formattedColors = colorScale.map((c) => {
return convertColorValue(c, this._output);
});
this._colorsReversed = orderColorsByLuminosity(formattedColors, 'toLight');

let reversedColor = orderColorsByLuminosity(formattedColors, 'toDark');
return reversedColor;
// Preserve the interpolation path. Sorting individual samples by measured
// lightness can interleave distant hues when that path is not monotonic.
this._colorsReversed = formattedColors;
return [...formattedColors].reverse();
}

_getDomains() {
Expand Down