fix(figma): export valid weights, angles, multipliers and aliases - #1528
Merged
Merged
Conversation
Report excluded dp dimensions as unsupported units rather than malformed values. Preserve leaf schemas through aliases and cover flat, set, audit, and CLI paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve variable references and mode-set targets, distinguish unsupported schemas from unresolved aliases, and cover the eleven skipped snapshot aliases without changing canonical data. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🦋 Changeset detectedLatest commit: 1dd44f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🎨 Token Changes ReportTokens Changed (0)Original Branch: This comment was automatically generated by the token diff tool. 🤖 |
Contributor
🧩 Component Schema Changes ReportNo component schema changes detected.This comment was automatically generated by the component schema diff tool. 🤖 |
Contributor
Run report for 1dd44f4aTotal time: 2m 3s | Comparison time: 3m 39s | Estimated savings: 1m 35s (43.7% faster)
Changed files |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bring the two verified Figma exporter fixes from
fix/figma-skipped-aliasesintomain:d5f191be: export named font weights as STRING and numeric angles as FLOAT, preserve alias target schema types, and report unsupported units.97f19fca: export unitless multipliers as FLOAT, preserve scalar and terminal mode-set VARIABLE_ALIAS references, and report unsupported alias targets.Keep existing variable IDs, mode behavior, overrides, and dangling-reference checks. Preserve the regression tests and SDK documentation from both commits. Extend the existing patch changeset for
@adobe/design-data-tuito cover both fixes, and normalize SDK README formatting.The PR changes only the exporter, its CLI audit output/tests, SDK documentation, and one changeset. It does not change canonical token data, package versions, credentials, or snapshot-release branches. Neither fix was present on
origin/main, by commit ancestry or patch equivalence, before opening this PR.Related Issue
Beads task:
spectrum-design-data-11k.24, under authoring epicspectrum-design-data-11k.Related completed verification tasks:
spectrum-design-data-98vrandspectrum-design-data-ti02.Motivation and Context
Valid font weights, angles, multiplier values, and their aliases were skipped or exported with the wrong Figma type. Fix the exporter rather than changing canonical data to work around it. Unsupported units and target schemas now have explicit audit diagnostics.
The exact published snapshot
@adobe/spectrum-tokens@0.0.0-size-token-taxonomy-20260930224730was previously verified offline and written to the Figma POC with complete readback. This task only packages those verified fixes for review; it performs no new Figma write or separate library Publish.How Has This Been Tested?
Local environment: macOS, repository-pinned Rust toolchain, Node.js 20.17.0, pnpm 10.17.1. Validation ran in a fresh isolated worktree with an existing Cargo target cache;
--forcebypassed Moon task caching.moon run sdk:test sdk:test-doc sdk:lint sdk:fmt-check --force --summary minimalorigin/mainat61c5e676: 1,525 tests passed, 2 skipped; 5 doctests passed, 1 ignored; workspace/all-target Clippy with warnings denied and Rust formatting passed.node tools/changeset-linter/src/cli.js check --fail-on-warningspnpm exec prettier --check .changeset/figma-multiplier-aliases.md sdk/README.mdgit diff --checkgh pr checks 1528 --repo adobe/spectrum-design-data --watch --interval 10The temporary merge was aborted after validation. During CI handoff, the remote branch independently merged
mainin1dd44f4a; its tree exactly matches the integration tree already tested locally. CI was then watched again and passed on that final head. The full non-SDK monorepo suite was not run locally; the Node CI job passed.Previously recorded verification artifacts were inspected, not regenerated: offline verification reported zero dangling aliases, unchanged effective default values, and matching offline/live payloads. The prior write readback verified 3,540 mode values, 1,142 alias values, and all 11 requested aliases; 1,559 unrelated variables remained unchanged, no variables were deleted, and numeric error stayed below the recorded
1e-6tolerance. No new network call to Figma was made for this PR.Screenshots (if appropriate):
Not applicable; exporter payload and audit regressions are covered by automated tests and prior readback evidence.
Types of changes
Checklist:
The Adobe CLA check passed. Merge is intentionally left to the maintainer after normal review and CI; auto-merge is not enabled.