fix(facets): limit Collections facet to classic ADS databases - #2382
Merged
thostetler merged 1 commit intoSep 30, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Filtering a full page can leave pagination requesting the wrong offset, making later collections unreachable.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
This PR limits the ADS Collections facet to classic databases while leaving saved queries for other collections intact.
Changes:
- Allowlist astronomy, physics, and general in the facet display.
- Add tests for filtering, counts, pagination, and query preservation.
| File | Description |
|---|---|
| test/mocha/js/wraps/database_facet.spec.js | Tests the Collections facet behavior. |
| src/js/wraps/database_facet.js | Filters the displayed collection options. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Collections facet now lists only astronomy, physics, and general; SciX subcategories (astrophysics, planetary, heliophysics, earthscience) no longer appear. A query already filtered to a hidden collection still runs unchanged — only the facet checkbox list is filtered.
thostetler
force-pushed
the
chore/collections-facet-ads-only
branch
from
September 30, 2026 18:25
e91bf08 to
8088b56
Compare
shinyichen
approved these changes
Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Collections facet was listing SciX subcategories (astrophysics, planetary, heliophysics, earthscience) alongside the classic ADS databases; this is the ADS UI, so it now offers only astronomy, physics, and general.