Repository navigation
fix(deps): pin sass and select2 to restore the release build - #2384
Merged
Merged
Conversation
sass floated past 1.100.0, which pulls in chokidar ^5 (ESM-only). grunt's sass task does a CommonJS require() of it, which throws ERR_REQUIRE_ESM on Node 18 and 20. Pin to ~1.99.0, the newest version with a dual CJS/ESM chokidar. select2 floated to 4.1.0, which requires Node >=24 (a hard error under Yarn 1) and dropped compat/matcher.js, which copy:libs needs; grunt-contrib-copy silently skips the missing file instead of failing, so the break only surfaced later as an ENOENT in generateBundles. Pin to ~4.0.13, the last 4.0.x release. Both floats were possible because the repo had no yarn.lock, so Yarn 1 ignored the committed package-lock.json and re-resolved every caret range on each deploy. Adding yarn.lock here.
Contributor
There was a problem hiding this comment.
Copilot review overview
馃數 Needs a closer look
The newly locked dependency graph updates many packages beyond the two targeted dependencies and warrants a verified release build.
Review effort: Balanced
Findings: None
What changed in this PR
Pins compatible Sass and Select2 release lines and introduces deterministic Yarn dependency resolution.
Changes:
- Restricts Sass and Select2 to compatible minor versions.
- Updates npm resolution metadata.
- Adds a Yarn 1 lockfile for reproducible deployments.
| File | Description |
|---|---|
package.json |
Restricts Sass and Select2 versions. |
package-lock.json |
Updates npm鈥檚 resolved dependency graph. |
yarn.lock |
Locks Yarn鈥檚 complete dependency graph. |
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release build broke on Node 18/20 with ERR_REQUIRE_ESM from sass's chokidar
dependency, and separately on select2 floating to a version that requires Node
>=24 and drops a file grunt needs.
pinned to ~4.0.13 (last 4.0.x, still ships compat/matcher.js).
package-lock.json, so Yarn ignored it and re-resolved every caret range on
each deploy. That is the root cause of both floats.