Skip to content

Updated Browse mode - #950

Open
shinyichen wants to merge 9 commits into
adsabs:masterfrom
shinyichen:browse-mode
Open

shinyichen wants to merge 9 commits into
adsabs:masterfrom
shinyichen:browse-mode

Conversation

@shinyichen

@shinyichen shinyichen commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Updates to browse mode:

Landing page

  • Add an intermediate page for "view all" of a certain facet collection from the landing page (collection page)
  • Include description for facet card

Collection page

  • The new intermediate page to see the whole facet group
Screenshot 2026-10-05 at 4 33 38 PM

Facet page

  • Add description (if has one)
  • Add a doctype filter (only in database)
  • View refereed histogram if doctype filter is selected
Screenshot 2026-10-05 at 4 34 54 PM Screenshot 2026-10-05 at 4 35 47 PM

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown

Bundle size

Shared by all pages: 627.8 kB (-0.0 kB) ⚪

Route Base Head Change
/browse/[collection] — 698.5 kB 🆕 added
/browse 817.3 kB 832.7 kB +15.4 kB 🔴

First load = polyfills + shared _app chunks + route chunks, gzipped.

@shinyichen
shinyichen requested a review from thostetler October 5, 2026 23:36
@codecov

codecov Bot commented Oct 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.9%. Comparing base (d6e8ab2) to head (4c4edb2).
⚠️ Report is 30 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d6e8ab2) and HEAD (4c4edb2). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d6e8ab2) HEAD (4c4edb2)
unittests 2 1
Additional details and impacted files
@@            Coverage Diff            @@
##           master    #950      +/-   ##
=========================================
- Coverage    67.9%   54.9%   -12.9%     
=========================================
  Files         379     375       -4     
  Lines       44188   11491   -32697     
  Branches     2380    2519     +139     
=========================================
- Hits        29974    6304   -23670     
+ Misses      14165    4555    -9610     
- Partials       49     632     +583     

see 423 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant