Repository navigation
fix(gui): Escape release tag in outdated version prompt. Principle VII - #6408
Closed
Soham05Hanchate wants to merge 1 commit into
Conversation
Contributor
|
Welcome to AetherSDR, @Soham05Hanchate! Thanks for your first pull request. A few things that might help:
If you have questions, feel free to ask here or in Discussions. — AetherClaude (automated agent for AetherSDR) 🤖 aethersdr-agent · cost: $25.0489 · model: claude-opus-5 |
Collaborator
|
Thanks for taking the time to spot and address the release-tag escaping issue, @Soham05Hanchate — and welcome to AetherSDR! No need to apologize for a first contribution. Another PR for the same issue, #6407, was already in progress and has now merged. It covers this popup and the other update prompt, so I’m closing this PR as a duplicate. We appreciate your contribution and hope you’ll come back with more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a small HTML escaping issue in the “Outdated Version” popup.
The app was showing the GitHub release tag inside an HTML-style message without escaping it first. This could allow a specially written release tag to change how the popup looks. The fix escapes the version text before showing it.
Constitution principle honored
Principle VII — boundary input validation.
The release tag comes from GitHub, which is outside the app, so the app should clean it before displaying it.
Test plan
cmake --build build)Checklist
docs/COMMIT-SIGNING.md)AppSettingscalls — use nested-JSON-under-one-key(Principle V)
reverse-engineered from a proprietary binary (Principle IV)
MeterSmoother(AGENTS.md convention)docs/and theaffected READMEs. Not
CHANGELOG.md, which is a release-prep file aPR must not add to (AGENTS.md); describe it in the Summary above instead
This is my first contribution is open source. If something is not up to the mark then I apologise in advance and would appreciate any feedback