Repository navigation
Conversation
Fixes aethersdr#6451. Stacked on aethersdr#6445 for the PTT Mic Override control.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6451.
Stacked on #6445 (
feat/ptt-mic-override, dependency headc2416ffc46a58dbc08588d60e48c22d39ae02c20). Merge #6445 first, then retarget this draft tomain. This PR's diff against its base contains only the bridge fixes.The agent automation bridge could not operate the PTT Mic Override configuration toggle, omitted existing slice DSP state, and lacked stable names for the shared DSP slider and TX REQ controls. Tree child selection already worked, but its reference omitted that capability.
registerTxConfigurationAction(). This uses the existing permission-required scoped-action machinery, acceptsclick,toggle, and validatedsetChecked, and captures the requested boolean before deferred delivery. It never calls a keying verb. TX permission, observe-only mode, permission revocation, widget lifetime, and disabled-state checks remain enforced. The button still follows the radio's echo.anfLevel,nrl/nrlLevel,nrs/nrsLevel,nrf/nrfLevel,anfl/anflLevel,mn/mnLevel,rnn, andanftto slice snapshots and property reads.mnLevelis passband position, not notch depth. These fields report existing model state and do not imply hardware support.dspLevelSlider, with an accessible name following its active target. Document pan-scoped targeting for multiple visible VFOs. Name the Interlocks group and its RCA/Accessory polarity controls, plus the PTT toggle.setCurrentTextselection, first-match semantics, unavailable-page redirect, and flat-row limits. Update the user guide and fallback warning.The generated touchpoint manifest increases the
TxKeyingMarker.hincluder count from 16 to 17: RadioSetupDialog now registers the configuration action at the control's creation site. This is existing GUI safety plumbing; it adds no vendor include or engine routing.Proof
The freshly built ARM64 app ran with an isolated settings profile,
AETHER_AUTOMATION_NO_TX=1, and only the demo simulator connected. The agent automation bridge captured the following:get slice 0 nrlLevel{"ok":true,"model":"slice","property":"nrlLevel","value":50}; all 13 added fields resolveinvoke radioSetupNavigation setCurrentText Transmit{"ok":true,"class":"QTreeWidget","action":"setCurrentText"}; named Interlocks group subsequently capturedgrab interlocksTxReqGroup{"ok":true,"class":"QGroupBox","width":617,"height":100}dspLevelSlider; real-widget test preserves the same slider throughNR level/ 37 →ANFL level/ 63 →POS level/ 21clickclick,setChecked, andclickAt, emits only the typedPttMicOverrideconfiguration request, and keeps the old checked/model value until injected status echoThe PTT test is socket-free and disconnected: it injects a reported setting into the actual TransmitModel and drives the actual dialog through the production bridge dispatcher. It also verifies denied permission, malformed/unsupported actions, observe-only mode, queued permission revocation, and queued reset/disabled-control behavior. It starts no radio transport. Live PTT configuration acceptance was not tested: the available physical radio runs firmware 4.2 and does not report this 4.3 setting. The demo correctly shows the toggle dimmed.
transmitting:falsewas confirmed in runtime evidence; no TX grant or keying was used on hardware.The named group can now be captured directly:
Local evidence is retained in
/tmp/fb-6451/(runtime-proof.json,runtime-navigation.json,tree-after.json, screenshots, build/test/mutation logs).Validation
automation_boundary_core_test,automation_cell_test,radio_setup_tx_timing_fields_test,automation_tx_watchdog_test, andvfo_dsp_launcher_width_test.nrlLevel, recursive child selection, PTT scoped registration, and target-following slider name; all four affected regression tests fail. Restore the changes, rebuild, and all five focused tests pass.npm ciand user-doc site build pass; generated user references and log-rule checks pass. Accessibility lint was run and remains warning-only.No new socket-owning test, dependency, default, wire grammar, visual layout, or keyboard binding is added. Linux/Windows builds and the full suite were not run locally; CI and maintainer review remain required.
Generated with OpenAI Codex.