Repository navigation
fix(hl2): the ALC gauge is described as what it measures. Principle VIII. - #6542
Conversation
…III. On the HL2 it is the audio peak after the ALC, before the modulator, not the peak reaching the wire. The shared description drops "SSB" so it stays right for the Flex meter of the same name (aethersdr#6235). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
c5886fa to
73ceed3
Compare
jensenpat
left a comment
There was a problem hiding this comment.
Reviewed exact rebased head 73ceed328eefe5d867b11b17cbc186d64b1583b2 against main 3fc45ebe7340863b257c6acd3d81274ec20627da. No blocking findings. Rebase was conflict-free; the contributor's authorship is preserved and the rebased commit has a verified signature.
RadioModel/seam isolation: RadioModel, IRadioBackend, RadioCapabilities, Flex/Icom backend directories, touchpoint manifest and tags are byte-identical to the base. No new includes, family branches, signals, timers, routing, commands, TX gates or persistence changes. Manual adversarial review completed; a separate automated code-review skill was unavailable.
The C++ diff contains only comments and two description substitutions. After removing comments and accounting for those exact substitutions, executable tokens match the base in all five changed C++ files. Shared Phone/CW accessibility text drops “SSB” from “post-software-ALC SSB peak (dBFS)”; Flex readings, units, scales and TX gating are unchanged. Icom retains its unchanged Percent branch and “radio-reported percent” description. HL2's meter description, comments and guide correctly identify the existing post-ALC/pre-modulator audio measurement; no DSP or measurement changes.
Validation on this head: all four boundary/manifest/capability/command-plane checks pass with identical base/head findings; git diff --check passes; generated docs reference check passes (8 pages); log-rule check passes (707 checks, 45 rules). No local build, CTest, bridge or live-radio test was run for this wording-only patch. Fresh hosted CI and Docs checks are pending and must pass before merge. Operator explicitly authorized the wording and merge after the isolation explanation.
Generated with OpenAI Codex (GPT-6 Astra)
Fixes #6235
Option 1 from #6235, in the form @NF0T and I settled on in the thread. No ruling was given between options 1 and 2; if the envelope peak (option 2) is wanted, close this.
Limits, first
docs/architecture/flex-meter-learnings.mdandtx-audio-signal-path.md, which describe that Flex meter, are not touched.Hl2TxDsp::processAudioBlock), so dropping "SSB" is correct there too. Not keyed in any mode.Change
PhoneCwApplet.cpp(three sites),PhoneCwApplet.h,MeterModel.h: "post-software-ALC SSB peak (dBFS)" becomes "post-software-ALC peak (dBFS)".Hl2TxDsp.cpp: the comment that said the value is "the signal reaching the wire" now says it is the audio peak before the modulator, at the ALC target while the ALC reduces.Hl2Backend.cpp: two comments, and the HL2 meter's description "Post-ALC transmit peak" becomes "Post-ALC audio peak, before the modulator".docs/user/docs/hermes-lite-2.md: one line saying what the ALC gauge shows on an HL2, and that it is not the transmitted envelope.Full ctest at
c5886fa0(08859e04merged withmain7864ef5; macOS, Qt 6.12.0,-j8): 801 tests, 799 passed.vkamp_connection_testfailed and passed on the serial rerun (Replace retained socket fixtures with injected and opt-in coverage #5254).kpa500_advanced_widget_testtimed out. It does the same on cleanmain94e3cd4 here, and only in our launchd test runner: it hangs inbackupSelectionRechecksReadAvailability. Started from a terminal it passes 9 of 9 in 0.3 s. This PR touches no KPA500 file.At
c5886fa0,check_engine_boundary,check_test_registrationandcheck_qsettings(--strict) andgen_touchpoint_manifest.py --checkpass.check_a11yon the twoPhoneCwAppletfiles at08859e04: 2 findings, the same 2 as on the base.73, ON8ST
🤖 Generated with Claude Code