Repository navigation
fix: point --no-skills projects upstream instead of at a missing .agents/ - #45
Merged
Merged
Conversation
…nts/ The generated AGENTS.md and README always referenced .agents/skills/tool-design/, even when the project was scaffolded with --no-skills and that directory does not exist. The skill is now copied before any template is rendered, and the docs are rendered with withSkills set to whether the copy actually happened. Without it, both link to the skill on GitHub and give `npx skills add agentailor/skills --skill tool-design`. A failed copy is covered by the same path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A project scaffolded with
--no-skillsstill got anAGENTS.md(and README) pointing at.agents/skills/tool-design/SKILL.md, which doesn't exist in that project.Fix
project-generator.tsnow copies the skill before rendering any template, and passeswithSkills: skillCopied. That is whether the copy actually happened, not just the flag, so a failed copy is handled the same way.AGENTS.mdand both READMEs link to https://github.com/agentailor/skills/tree/main/tool-design and give:-a universalon purpose: whoever opted out picks the agent. The fallback hint printed after a failed copy keeps-a universal.src/templates/common/skill-readme.ts, shared by the HTTP and stdio templates.AGENTS.mdnow documents the ordering rule.Output with the skill installed (the default) is unchanged, apart from the README link now pointing at the skill's folder instead of the repo root.
Testing
AGENTS.md(HTTP + stdio) and the README section, plus both transport READMEs.npm run build,npm test(412 passing) andnpm run lintpass.--name=a(has.agents/, docs point at it) and--name=b --stdio --no-skills(no.agents/, docs show the link and command).🤖 Generated with Claude Code