Repository navigation
ci: use latest patched Node LTS for build and registry sync - #2464
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node-version: "lts/*"instead oflatestin the build and registry-doc synchronization workflows.check-latest: trueso LTS selection does not reuse a runner-cached patch without checking for a newer release.Why
latestselects Node Current (26), not the latest LTS (24). Node here is build/docs tooling, so LTS is the intended default and matches the other ACP repositories.This is a runtime-policy alignment, not a claim that the previous selection was vulnerable: the sampled build and sync jobs already resolved patched Node 26.12.1. The new selector should resolve patched LTS 24.22.1 today.
Validation
npm ci: passed.npm run check: passed, including all three Clippy configurations, formatting, spelling, 497 unit tests and 2 doctests.lts/*, and enablecheck-latest.git diff --check: passed; only the two workflow files changed.Risk / rollout
CI-only change from Node Current to the supported LTS line; no SDK/runtime/API changes. Full local checks passed on the selected LTS patch. Check the next build and synchronization setup-node logs for a patched LTS release. Reverting restores the previous Current-release policy, not a production rollback.