Repository navigation
docs(rfd): describe read-only subagent configuration - #2468
Merged
Merged
Conversation
This was referenced Oct 23, 2026
benbrandt
added a commit
to agentclientprotocol/claude-agent-acp
that referenced
this pull request
Oct 23, 2026
## Summary Expose the observed configuration of RFD subagent sessions using the same config-option IDs as ordinary sessions, without granting client-initiated configuration changes. - Report model from child responses and model-switch hooks, and mode, applied reasoning effort, and agent type from child-attributed SDK hooks. - Merge partial observations into complete, ordered config snapshots; buffer early observations until truthful child announcement and serialize concurrent publications. - Advertise only each observed current value. Do not inherit parent settings or invent child Fast-mode state. - Keep child plan-mode and model-switch hooks from changing the parent's configuration. - Cover initial/changed settings, announcement ordering, publication failures, root isolation, and hook registration in both protocol versions; update v2 scenario snapshots. ## Related Protocol clarification: agentclientprotocol/agent-client-protocol#2468 Zed client implementation: zed-industries/zed#66058 ## Validation Passed after rebasing onto current `main`: - `npm run build` - `npm run check` - `npm run test:run -- --silent`: 3,294 passed, 30 skipped. No live Claude-to-Zed smoke test was run. Settings are reported only when observed from the SDK; availability depends on runtime support and events received.
buvidk1234
pushed a commit
to buvidk1234/zed
that referenced
this pull request
Oct 24, 2026
…6058) Show the actual configuration reported by exposed ACP subagents without offering controls their sessions do not support. - Register an empty config provider when a child is announced, so the first asynchronous snapshot reaches the UI in both ACP versions. - Expose a read-only provider that rejects configuration mutations before sending a wire request. - Render child settings as labels below the transcript, including boolean values, while leaving the message composer unavailable. - Block picker/cycling actions and stale controls from changing child settings or saving defaults. - Test snapshot replacement, watcher updates, parent isolation, and read-only behavior. Protocol clarification: agentclientprotocol/agent-client-protocol#2468 Claude adapter implementation: agentclientprotocol/claude-agent-acp#1417 Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Clarify how exposed subagent sessions report their current configuration without granting clients permission to change it.
config_option_updateon the child's session ID for initial and subsequent complete snapshots.No protocol fields, methods, or capabilities are added.
Validation
npm run checkpassed after rebasing onto currentmain.Companion implementations