Repository navigation
Conversation
Signed-off-by: Emre K <110906681+kocaemre@users.noreply.github.com>
kocaemre
force-pushed
the
fix/plan-mode-reasoning-effort
branch
from
October 10, 2026 17:16
9a9992b to
7f1d277
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plan_mode_reasoning_efforton entering Plan mode, expose the active effort in ACP config options, and restore the ordinary effort on exit.Closes #364
Test Plan
npm run test -- src/__tests__/CodexACPAgent/session-config-options.test.ts -t 'uses plan_mode_reasoning_effort while Plan mode is active'— failed: sentlowinstead of configuredhigh.npm run test -- src/__tests__/app-server-recovery/recovery.test.ts -t 'keeps a collaboration mode chosen while the app-server was down'— failed:Connection is disposedonconfig/read.npm run test -- src/__tests__/app-server-recovery/recovery.test.ts src/__tests__/CodexACPAgent/session-config-options.test.ts— 82 passed.npm test— 1490 passed, 36 skipped (91 files passed, 7 skipped).npm run typecheck;npm run build;git diff --check upstream/main..HEAD— passed.