Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An explicit
sandbox_workspace_write.network_access = truereaches Codex session configuration, but ordinary prompts replace it with the mode's hardcodedfalse. Honor the setting when building workspace-write turn policies, including settings resolved fromconfig.tomlfor the session's working directory.Only the network field changes. Preserve writable roots, temporary-directory flags, approval policy/reviewer, shared presets, and other sandbox types. Recheck cancellation after resolving file configuration, so a cancelled prompt cannot start a late turn.
Closes #406. Related to #561 and #368; this proposal also covers file-backed effective configuration, beyond the supplied CODEX_CONFIG object. No new mode, environment variable, dependency, or generated API type is needed.
Evidence
202e66e63343ec4f5a5e35ab590251d813d129ca, the new regression suite had 7 failures / 3 passes. Both explicit-session and file-config enable cases sentnetworkAccess: falseinstead oftrue.After: all 10 network-policy cases pass. An additional ACP cancellation test passes while
config/readis unresolved and verifies that its eventual response does not start a turn.config/readRPC: a TOML network flag producedworkspaceWritewithnetworkAccess: true.runTurnwas intercepted, so this made zero model requests; it is not a provider-backed networking E2E claim.npm run typecheck,npm run build, andgit diff --checkpass.npm test: 1,497 passed, 36 skipped, 3 failed. The same threeCodexHomeWatcherfilesystem-notification tests fail on the unmodified upstream SHA in this macOS environment (7 passed / 3 failed when isolated). This PR does not change the watcher.npm run bundle:allpassed with the CI-pinned Bun 1.3.11 for all six targets: Linux, macOS, and Windows, each x64/arm64. The native macOS arm64 executable also passed--version.Merge Danger
Door: Two-way
No persisted state or protocol schema changes. Reverting restores the old turn-policy mapping.
Blast Radius: Workspace
Workspace-write turns now follow explicitly configured networking. Read-only/full-access and users without a configured network flag retain their previous policy. The only new RPC is a read-only
config/readwhen CODEX_CONFIG does not supply a valid boolean.