Repository navigation
compile our crates on every run - #155
Merged
Merged
Conversation
Signed-off-by: Peter Jausovec <peter.jausovec@solo.io>
ilackarms
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on
feat/inventory-watchfailed becauseagentdesktop-agentwas compiled against cached builds ofagentdesktop-coreandagentdesktop-protofrom before #146 (run).The Linux job cached the repo's own crates and set each source file's timestamp to its commit time, so Cargo would reuse those builds. That breaks when a cache is built from older source after a newer commit's timestamp. Six merges to main within two minutes shared one cache key. The run for #149 saved the cache after #146 was committed, so its core and proto builds looked newer than #146's sources and Cargo reused them. The same gap can let a PR pass while testing old code.
cache-workspace-crates: false. Dependencies are still cached.fetch-depth: 0, which only that step needed.The repo's crates now compile on every run. The Windows job is unchanged: it doesn't restore timestamps, so its crates already rebuild every run. Open PRs need a new push to pick this up, because a re-run uses the old workflow.