Repository navigation
[Automated] Draft docs (agentgateway): docs: add note about advisor tools - #1386
Merged
Merged
Conversation
…ools Signed-off-by: GitHub Action <action@github.com>
Signed-off-by: Art Berger <art.berger@solo.io>
allowedModels has checked only the top-level request model since it was added, so v1.6.0 behaves the same. Signed-off-by: Art Berger <art.berger@solo.io>
artberger
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agentgateway/agentgateway#4101 — docs: add note about advisor tools
Docs versions:
standalone/main. Not planned forkubernetes/main: no page found there. Check whether the change applies in that mode tooWhat changes for users: No runtime behavior changes. Standalone API key
allowedModelschecks only the request's top-level model, so provider server-side tools such as the Anthropic advisor tool can use models outside the key's allowed list.What the docs now say: The API Key authentication page and the per-key budgets guide now scope
allowedModelsto the top-level request model and call out that provider server-side tool models are not checked.Not verified: No standalone run; the configuration and server-side-tool behavior are unrun.
How
agentgateway-4101was drafted, and what was not verifiedPlan, and what changed it
_index.mdand validation targets did not own the field; grepping the docs checkout foundapikey-authn.mdandper-key.mdas the prose owners.Why a documentation change is necessary
The code pull request adds a doc-comment and schema-reference caveat for
allowedModels: only the request's top-level model is checked, not models used by provider server-side tools. The authored API key and per-key budget pages said that the key could reach or deny models without that boundary, which could make readers expectallowedModelsto block an Anthropic advisor tool's model selection.What changed on disk
content/docs/standalone/main/documentation/configuration/security/apikey-authn.md: scopesallowedModelsto the top-level request model and notes that provider server-side tool models are not checked.content/docs/standalone/main/documentation/llm/cost-controls/budget-limits/per-key.md: updates the field table, guide intro, rejection description, and access-mode table to use top-level-model wording.How to verify this change
allowedModelsconfiguration in the per-key budgets guide and start standalone agentgateway withagentgateway -f config.yaml.403and themodel_not_allowedcode.allowedModelsbut whose provider server-side tool uses a different model. The API key policy should not reject the request withmodel_not_allowedbecause of the tool's model.Proposed release note
No release note: this is a docs-only clarification of generated schema/reference text and authored guide prose. The dossier shows no runtime behavior, default, or upgrade action changed.
What was not verified
How the pages were chosen (triage report)
Draft a documentation change
agentgateway/agentgateway#4101 — docs: add note about advisor tools
agentgateway/website--validate-onlyafter drafting, and commands are unrunDraft branch:
pr-tracker-draft-agentgateway-4101