Soften unverifiable test-count claim in CHANGELOG.md - #16
Merged
Merged
Conversation
… launch copy Precise historical test count can't be safely re-verified against the pre-fix commit without contaminated results, and the current count (1000) includes tests added by this very fix, so it would misstate what those tests could or couldn't see.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found during a final verification pass on external-facing copy: CHANGELOG.md's cross-process-locking entry cited "858 single-process tests." That number is accurate only as a snapshot at commit 5a3ae48, and the current count (1000) includes tests added by that very fix — so neither number is safe to state as "tests that couldn't see this bug" without misleading. Softened to "hundreds," matching the same fix applied to the launch copy.