Repository navigation
Run CI on Apple silicon now that only the darwin-arm64 CLI is bundled - #18
Merged
Merged
Conversation
plugin:validate runs the bundled CLI's --help to check its global options against the plugin's restricted-option guard. Since #17 the package bundles only the darwin-arm64 CLI, so on the ubuntu runner validation failed with "does not bundle the AgentMail CLI for linux-x64". - Run the full job on macos-latest so validation exercises the shipped executable. - Add a test-linux job (build + tests) so the email channel, which most gateways run on Linux, stays tested there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
CI failed on #17 and on
mainafter it merged:plugin:validateruns the bundled CLI's--helpon the host, to check the CLI's global options against the plugin's restricted-option guard. #17 bundles only the darwin-arm64 CLI so the package can publish to ClawHub, but CI ran onubuntu-latest. I verified #17 only on a darwin-arm64 machine and missed that.What changed
macos-latest(Apple silicon), soplugin:validateexercises the executable we ship. The restricted-option check stays intact rather than being skipped.test-linuxjob (npm ci, build,npm testonubuntu-latest). Most gateways run the email channel on Linux, so its tests keep running there.Verification
test-linuxsteps pass innode:24.15.0on x86_64 under Docker: 241 tests.testjob steps (plugin:check,plugin:validate,pack:verify,npm test) pass on darwin-arm64.0.2.2 will be published from this PR's merge commit once CI is green.
🤖 Generated with Claude Code