Repository navigation
Test GPS info on real camera trap images - #250
Merged
Merged
Conversation
Adds test_get_gps_info_real_images, using the gps-tests folder of the test data package via md_tests.download_test_data(). The synthetic-image test now only covers cases that don't occur in real images.
Owner
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #247 and #248.
Adds
test_get_gps_info_real_images()tomegadetector/data_management/read_exif.py, which runsget_gps_info(),has_gps_info()andget_exif_lat_lon()on the real camera trap images in the newgps-testsfolder of the test data package, downloaded withmd_tests.download_test_data(). Itcovers valid GPS (including zero degrees latitude), null island (N/E and S/W refs, with and without
check_for_null_island), junk GPS values (reported as present, with no location), GPS tags withoutlat/lon, an empty GPS IFD, no GPS, no EXIF, and a corrupt image, each as a filename, a PIL image, and
an EXIF dict. It also fails if an image is added to
gps-testswithout an expected result.Everything the real images now cover is removed from the synthetic-image test, which keeps only the
cases that don't occur in real images: null island stored as NaN, a missing file, an
exif_tagsfield that is
None, and string-valued GPS values.