Skip to content

docs: drop removed OpaqueProvider from AttestationUnsupported row - #239

Merged
imran-siddique merged 1 commit into
mainfrom
docs/error-codes-drop-removed-provider
Oct 15, 2026
Merged

imran-siddique merged 1 commit into
mainfrom
docs/error-codes-drop-removed-provider

Conversation

@imran-siddique

Copy link
Copy Markdown
Member

#236 removed OpaqueProvider, but the AttestationUnsupported row in docs/spec/error-codes.md still listed it as a source of the error. This drops that clause. The remaining text matches the code: AttestationUnsupported is raised by a provider's attest when the host lacks what its collector needs (tee/base.py, tee/sev_snp.py) and by the hardware acceptance run.

Docs only, one line.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Imran Siddique <45405841+imran-siddique@users.noreply.github.com>
@imran-siddique
imran-siddique requested review from a team, carloshvp and zohebk8s as code owners October 13, 2026 14:49
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@carloshvp carloshvp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed exact head a24b1e9370f8825de08853fc42ed684a3567ef8c in an isolated checkout. Removing the OpaqueProvider clause matches the implementation: that provider is absent from src, while the active TPM, SEV-SNP, TDX/configfs-TSM providers and hardware-acceptance path raise AttestationUnsupported when the required collection capability is unavailable. BaseProvider documents the same behavior.

The diff removes only the obsolete clause. The status, detail guidance and existing Peer Attestation link are preserved, and the linked document exists. The commit has the required Signed-off-by trailer. The CR-at-EOL-aware diff check and merge simulation against fetched main passed; hosted checks are successful or expected skips. Approving.

@imran-siddique
imran-siddique merged commit 7fbb798 into main Oct 15, 2026
15 checks passed
@imran-siddique
imran-siddique deleted the docs/error-codes-drop-removed-provider branch October 15, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants