Skip to content

governance: hand maintainer coverage to community maintainers #757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
imran-siddique merged 2 commits into from
Oct 15, 2026
Merged

governance: hand maintainer coverage to community maintainers #757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0417924
governance: hand maintainer coverage to community maintainers
imran-siddique Oct 14, 2026
6cba369
docs(maintainers): add noah-ing as Reviewer
imran-siddique Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/maintainers.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,7 @@
"carloshvp",
"qubeena07",
"zohebk8s",
"pforest",
"Qiang-Xu",
"rajnisht7",
"podcastinator",
"AaronRoeF"
"rajnisht7"
],
"security_paths": [
"src/cmcp_runtime/audit/",
Expand Down
25 changes: 17 additions & 8 deletions .github/workflows/require-maintainer-approval.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,26 @@ jobs:
pull_number: context.payload.pull_request.number,
});
// Read only reviewed base-branch data. Never execute or read policy from a PR head.
const readPolicy = async ref => (await github.rest.repos.getContent({
owner: context.repo.owner, repo: context.repo.repo,
path: '.github/maintainers.json', ref,
})).data;
let file;
try {
({ data: file } = await github.rest.repos.getContent({
owner: context.repo.owner, repo: context.repo.repo,
path: '.github/maintainers.json', ref: pr.base.sha,
}));
file = await readPolicy(pr.base.sha);
} catch (error) {
// One-commit bootstrap: the initial policy PR must be reviewable before its
// policy file exists on main. Missing policy on any later base fails closed.
if (error.status !== 404 || pr.base.sha !== "316ecf3176cb2d72c4f26060e1709016dd8f0b16") throw error;
file = { encoding: 'base64', content: Buffer.from(JSON.stringify({"schema":1,"repository":"cmcp","source":"agentrust-io/.github:maintainers/roster.json","maintainers":["imran-siddique","carloshvp","qubeena07","zohebk8s","pforest","Qiang-Xu","rajnisht7","podcastinator","AaronRoeF"],"security_paths":["src/cmcp_runtime/audit/","src/cmcp_runtime/tee/","src/cmcp_runtime/policy/","src/cmcp_verify/"],"security_approvals":2})).toString('base64') };
if (error.status !== 404) throw error;
// A pull request opened before the policy file landed keeps that older base.sha,
// so read the policy at the tip of its base branch, which is reviewed data too.
// Qualified, so a tag with the branch's name cannot stand in for it.
try {
file = await readPolicy('refs/heads/' + pr.base.ref);
} catch (error) {
// One-commit bootstrap: the initial policy PR must be reviewable before its
// policy file exists on main. Missing policy on any later base fails closed.
if (error.status !== 404 || pr.base.sha !== "316ecf3176cb2d72c4f26060e1709016dd8f0b16") throw error;
file = { encoding: 'base64', content: Buffer.from(JSON.stringify({"schema":1,"repository":"cmcp","source":"agentrust-io/.github:maintainers/roster.json","maintainers":["imran-siddique","carloshvp","qubeena07","zohebk8s","rajnisht7"],"security_paths":["src/cmcp_runtime/audit/","src/cmcp_runtime/tee/","src/cmcp_runtime/policy/","src/cmcp_verify/"],"security_approvals":2})).toString('base64') };
}
}
if (Array.isArray(file) || file.encoding !== 'base64') {
throw new Error('Missing base-branch maintainer policy');
Expand Down
15 changes: 12 additions & 3 deletions MAINTAINERS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@

| Name | GitHub | Affiliation | Role |
|------|--------|-------------|------|
| Imran Siddique | @imran-siddique | OPAQUE Systems | Project Lead |
| Rishabh Poddar | @podcastinator | OPAQUE Systems | Maintainer |
| Aaron Fulkerson | @AaronRoeF | OPAQUE Systems | Maintainer |
| Imran Siddique | @imran-siddique | AgenTrust-io | Project Lead |

The Project Lead has final decision authority on architecture, conformance
requirements, and Maintainer appointments.
Expand Down Expand Up @@ -38,6 +36,11 @@ To be considered for maintainer status you must:

Maintainers who are no longer active may move to emeritus status. Emeritus maintainers are listed here for recognition but do not hold merge rights or voting privileges.

| Name | GitHub |
|---|---|
| Rishabh Poddar | @podcastinator |
| Aaron Fulkerson | @AaronRoeF |

## Changes to This File

Changes to MAINTAINERS.md must be approved by at least one existing maintainer.
Expand All @@ -52,3 +55,9 @@ Changes to MAINTAINERS.md must be approved by at least one existing maintainer.
| Rajnish Tiwari | [@rajnisht7](https://github.com/rajnisht7) | [Project Lead announcement](https://github.com/orgs/agentrust-io/discussions/40) |

These appointments cover this repository. CODEOWNERS determines which paths each reviewer can approve for protected merges.

## Reviewers

| Name | GitHub | Since |
|---|---|---|
| Noah Ingwers | [@noah-ing](https://github.com/noah-ing) | 2026-10-14, [accepted](https://github.com/agentrust-io/.github/issues/60#issuecomment-6179377337) |
Loading