Repository navigation
Conversation
Address the Windows portability findings on upstream agentrust-io#322. Add behavioral regression controls for closed connections and non-UTF-8 platform defaults. Signed-off-by: Srinivasa Dinakar <78673153+dinakarjs@users.noreply.github.com>
dinakarjs
requested review from
a team,
carloshvp and
imran-siddique
as code owners
October 16, 2026 02:53
Contributor
|
🟡 Contributor Check: MEDIUM
Automated check by AgenTrust Contributor Check. |
github-actions
Bot
added
the
needs-review:MEDIUM
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses Imran's Windows portability findings on #322. The producer's read connection now closes before TemporaryDirectory cleanup, and the scanner reads catalogs and JSONL as UTF-8. The Unicode-separator fixture also writes UTF-8 explicitly. Document the encoding contract.
This companion PR targets #322's feature branch so only the six-file portability correction is shown; it retains Carlos's adapter implementation and ownership. Integrate it into #322 before merge, or retarget/cherry-pick the correction onto main after #322 lands.
Validation on Linux/Python 3.12.14: 132 tests pass with each installed released cmcp-runtime 0.2.0 and 0.7.0. Added behavioral tests observe closure of every SQLite connection and correct non-ASCII identity handling under a simulated cp1252 default. Reverting each respective fix makes its regression fail. Repository CI Ruff scope (E4/E7/E9/F, target py39), compileall and diff checks pass. No native Windows execution claimed. No source-authentication, gateway, TEE or end-to-end execution claim. DCO signed off.