Repository navigation
fix(service): mirror admitted personal chat events - #3512
Open
NewPeople-star wants to merge 1 commit into
Open
NewPeople-star wants to merge 1 commit into
NewPeople-star wants to merge 1 commit into
Conversation
|
itcast seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed Agent personal Chat executes without an orchestration Attempt. Its messages were persisted in the data-plane event log, but
ManagedEventOutbox.enqueue()discarded every event whose scope was not managed, so the control-plane conversation and events views remained empty.Allow unscoped events into the durable outbox when the session has a persisted admission without an Attempt. Keep skipping generic unscoped events for task sessions, which the control plane rejects and which would otherwise block ordered delivery. Scoped task events retain their existing immutable reports and Attempt fences.
Personal-chat rows use an empty local
attempt_idto remain compatible with existing NOT NULL schemas; reports omit all orchestration fence fields. This requires no schema migration or control-plane API change. Events produced before the first execution admission retain their existing behavior.Regression coverage exercises message projection, replay deduplication, transaction rollback, per-session delivery ordering, retry across outbox recreation, and task-session isolation. English and Chinese session documentation are updated.
Fixes #3501
Validation:
Files.createSymbolicLink, before the assertion under test.git diff --checkpassed.mint broken-linksreports 2,208 links in 326 files on Windows, including existing local pages. Running it against the original, unmodified documentation produced identical findings. The added paragraphs introduce no links or headings.