Repository navigation
Conversation
saddddboi
force-pushed
the
codex/fix-memory-watermark-3510
branch
from
October 12, 2026 01:21
c2da3e4 to
97ccb96
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
2.1.0-SNAPSHOT
Description
Closes #3510.
When two isolated users share a BaseStore, consolidating Alice's daily ledger advances a global watermark that can cause Bob's unprocessed ledger to be skipped. Bob's existing MEMORY.md then remains stale.
Resolve the distributed watermark namespace through WorkspaceManager's configured NamespaceFactory for both reads and CAS writes. Preserve the legacy shared slot for empty namespace mappings and the filesystem-state fallback. Isolated scopes ignore the old global cursor, since it may describe another user's consolidation progress.
Add regression coverage for USER isolation, two sessions of the same user, repeated consolidation, legacy cursor fallback, missing namespace factories, null-context normalization, and CAS conflict retries. Update the English and Chinese Harness memory guides. No public API signatures change.
Validation
65a35d40plus this fix.The full repository test suite and a real distributed-database integration were not run locally. The committed regression tests use deterministic model responses and require no provider credentials.
Documentation checks:
npm ci,npm test,npm run validate, andnpm run broken-linkswith Node 22 on Linux.Checklist
mvn spotless:applymvn test) — the relevant 94 tests pass; the full repository suite was not run locally.