Repository navigation
Fix SVG dimensions from the captured terminal grid - #12
Merged
Merged
Conversation
Use TermCols/TermRows from xterm.js to snap the inner SVG viewport to the exact character grid, eliminating black bars and subpixel gaps. Set background color on the outer <svg> element to prevent edge rendering artifacts.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVG output now fits the captured terminal rows and columns. Capture records the actual grid and cell metrics. Export rounds fractional cell extents up to full pixels and preserves padding, window bars, and margins.
The repair integrates current main without rewriting contributor history. It keeps rounded corner transparency and copies style settings before sizing. Raster capture settings remain unchanged. Invalid cell metrics use the existing font-size fallback.
Validation:
Linux and Windows builds prove compilation. Their native browser behavior requires hosted tests.
Resolves PR 7. The replacement retains its original commit and integrates current main. A contributor-fork write check failed at Git LFS authentication. This branch publishes the repaired proposal in AgentStation.