Repository navigation
Embed installed SVG fonts before capture - #15
Merged
Merged
Conversation
Resolve the configured font family using fc-match, subset it to only the glyphs used in the SVG frames via pyftsubset (if available), and embed the result as a base64 @font-face rule. Falls back to embedding the full font file when pyftsubset is not installed.
6 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set FontFamily "Menlo"now embeds the installed face for SVG output when Fontconfig is available. The selected bytes load before terminal sizing and capture. Optional FontTools subsets displayed terminal, cursor, and title glyphs, with full-face fallback on failure.This completes the automatic setup and file-size benefits from #8 and retains its original commits. Explicit flag and environment paths take priority and preserve exact bytes, including video-only capture. Separate title fonts and collection face indices remain distinct. Generic families and fallback stacks retain their current behavior.
The repair escapes font names at the JavaScript, CSS, and XML boundaries. It preserves raster title families, prepares output fonts before successful browser teardown, and tests final even viewport dimensions to prevent an extra column.
Validation:
The contributor fork rejected the authenticated LFS lock check during a dry-run push. This replacement uses an owned branch and preserves the contributor’s published history.
Pre-PR autoreview passes with no P0 findings. The exact-content secret scan is clean.
Resolves #8.