Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
When a nested reference resolves to a falsy value, the endpoint documentation generator calls
.pop()on a plain properties object and throwsTypeError: temp.properties.pop is not a function. Usedelete temp.properties[key]to remove that property, andforEachfor the traversal whose return value is unused.Checklist
git diff --checkpass.Additional Notes
Validation uses a small local Node.js harness that executes the existing
resolveReffunction with a controlled$refs.getimplementation. The failing fixture returnsfalse; this verifies the existing falsy-removal branch, not end-to-end parsing of an invalid OpenAPI document. The full website build and documentation generation have not been run. This does not add recovery for missing references rejected by the OpenAPI parser.Developed with AI assistance.
References, Fixes and Closes
Fixes #133