Bound captured extension route backtracking - #188
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
parsePrefixforPI_Extensionthat returnsNothingwhen the right-hand side requires split enumeration and the incoming segment contains more thanmaximumExtensionSeparatorsdots, implemented inreroute/src/Web/Routing/SafeRouting.hs.maximumExtensionSeparators :: Int(set to16) and helperextensionNeedsSearchso fixed literal suffix paths (PI_StaticConsandPI_Empty) keep the existing fast single-split behavior.extensionSplits/dotSplitsbehavior for normal cases so functionality is preserved for benign inputs and literal extensions.reroute/test/Web/Routing/SafeRoutingSpec.hsthat assert adversarial chained-capture inputs are rejected and that many-dot filenames still match fixed literal extensions.Testing
git diff --checkto validate patch formatting and it passed.2^16) and it passed.cabal/stack/ghc) was not executed because the toolchain is not available in the environment, soreroutetests were not run locally.Codex Task