Skip to content

Fix: use correct units for body_surface_temperature_in_K (K instead of K^4) - #222

Open
kevinziroldi wants to merge 1 commit into
aidotse:mainfrom
kevinziroldi:fix/thermal-body-temperature-default
Open

Fix: use correct units for body_surface_temperature_in_K (K instead of K^4)#222
kevinziroldi wants to merge 1 commit into
aidotse:mainfrom
kevinziroldi:fix/thermal-body-temperature-default

Conversation

@kevinziroldi

Copy link
Copy Markdown

Problem

body_surface_temperature_in_K was documented and named as a temperature in Kelvin,
but the default value was 288**4, i.e. already T⁴. This leads to effectively using
T¹⁶ in the body IR term (_C_body_emission applies **4 again).

Fix

Change default from 288**4 to 288.0.

…*4 to 288 to match the documentation and make the value realistic
@gomezzz
gomezzz self-requested a review August 17, 2026 08:15
@gomezzz

gomezzz commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Hi @kevinziroldi ,

Thanks for catching this. You're right that 288**4 contradicts both the parameter name and the docstring, and _initialize_constants does square it up to T¹⁶.
Thankfully, I think, in practice it never took effect: ThermalModel isn't part of the public API, and its only construction site, ActorBuilder.set_thermal_model ( https://github.com/aidotse/PASEOS/blob/main/paseos/actors/actor_builder.py#L451 ) , always passes body_surface_temperature_in_K explicitly with a correct default of 288. So the bad value was only reachable by instantiating ThermalModel directly.
Still worth fixing. I'll take a closer look shortly! (Will likely aim to fix the CI first :) )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants