Skip to content

Keep release checks stable across checkout and process startup - #25

Merged
joowon-jang merged 4 commits into
mainfrom
release/v0.3.2-generated-line-endings
Oct 27, 2026
Merged

joowon-jang merged 4 commits into
mainfrom
release/v0.3.2-generated-line-endings

Conversation

@joowon-jang

@joowon-jang joowon-jang commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Windows release verification rejects generated provider JSON when automatic CRLF checkout changes canonical LF bytes. The same checkout breaks the pinned AppImage input parser and license check. Preserve LF for those inputs and run the provider and packaging checks early in Windows PR CI.

Keep process lifecycle tests independent of interpreter startup:

  • Windows: emit the same 300,000 synthetic bytes through a temporary file and cmd type, retaining the 10-second capture deadline, 256-KiB content assertions and cancellation cases.
  • macOS: poll the approval future until its Node fixture connects, then start the same 2-second cancellation/deadline test. Keep the 10-second readiness and 5-second cleanup budgets.

Application behavior, runtime pins, generated data, fixture contents and license notices are unchanged.

Validation:

  • A real core.autocrlf=true checkout passes provider synchronization, all 64 packaging/runtime tooling tests, direct tests and the full npm pipeline (221 files / 2597 UI tests, coverage thresholds retained).
  • Rust formatting passes.
  • Hosted Windows CI on the previous head f4aa102 passes the provider checks, packaging tooling, full native tests, clean-home CLI, real CPU lifecycle and Credential Manager roundtrip. Hosted frontend and macOS ARM also passed on that head.
  • That prior macOS Intel run exposed the readiness/deadline race corrected in 10cea07. Do not claim this final macOS fix validated until latest CI completes.
  • Required final CI: https://github.com/aiolm/AioLM/actions/runs/40478697677 on 10cea07. All five jobs must pass before merge.

Release follow-through: PR #24 already merged v0.3.2 into main at a83d5af. The first Desktop release failed Windows verification and was superseded; v0.3.2 has not been published. Merge this correction after its checks, then verify the automatic main CI and Desktop release, the existing release-publish environment review, and all published assets/checksums. Do not precreate a tag or draft release: the workflow skips an existing release. Keep the existing unsigned/ad-hoc signing notices and the documented SmolVLM media-content limitation.

@joowon-jang joowon-jang changed the title Preserve canonical release inputs on Windows checkout Keep Windows release checks stable across checkout and shell startup Oct 27, 2026
@joowon-jang joowon-jang changed the title Keep Windows release checks stable across checkout and shell startup Keep release checks stable across checkout and process startup Oct 27, 2026
@joowon-jang
joowon-jang merged commit e439b52 into main Oct 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant