Repository navigation
Conversation
|
Note 📝 PR Converted to Draft More info...Thank you for creating this PR. As a policy to protect our engineers' time, Airbyte requires all PRs to be created first in draft status. Your PR has been automatically converted to draft status in respect for this policy. As soon as your PR is ready for formal review, you can proceed to convert the PR to "ready for review" status by clicking the "Ready for review" button at the bottom of the PR page. To skip draft status in future PRs, please include |
👋 Welcome to PyAirbyte!Thank you for your contribution from HootRock/PyAirbyte! We're excited to have you in the Airbyte community. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/HootRock/PyAirbyte.git@fix/sql-dataset-filtered-conversions' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/HootRock/PyAirbyte.git@fix/sql-dataset-filtered-conversions'PR Slash CommandsAs needed or by request, Airbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesIf you have any questions, feel free to ask in the PR comments or join our community:
|
CachedDataset.with_filter()filters iteration andlen(), but itsSQLDatasetconversions reload the entire stream by name. For a three-row table,with_filter("id > 1")iterates two rows whileto_pandas()andto_arrow()return all three.Execute the saved SQLAlchemy query for both conversions. Arrow reads the query in the requested chunks and reconciles compatible chunk schemas so that a first filtered batch containing only nulls does not reject later values. Whole-table
CachedDatasetconversion remains on its existing path.Validation:
source-testconnector and DuckDB in both installer modes; all eight failed on the original code.test_get_time_strexplicitly deselected. The unfiltered run failed only that timezone assertion; the original main-branch function reproduces the same08:00:00versus00:00:00mismatch in UTC+8.No credentialed database integrations were run.
reviewed and tested locally.