[xtqqczze]

See crossterm-rs/crossterm#1101

[alejandroqh]

Hi @xtqqczze, thanks for the PR and for the heads-up about crossterm-rs/crossterm#1101!

I can't merge this as-is, though. filedescriptor and use-dev-tty aren't equivalent: in crossterm 0.29 the filedescriptor feature is a no-op for term39 (no code is gated on it), while use-dev-tty switches the Unix event source from mio to poll/select. That backend has an open bug (crossterm-rs/crossterm#839) where event::poll(Duration::ZERO) never returns buffered events, and term39's event loop relies on a zero-timeout poll to drain events each frame. With this change it processes one event per frame instead of a batch, which I measured as 20 keystrokes taking 20 frames instead of 1. Fast typing and mouse drags would lag noticeably.

Since the goal is just forward compatibility with #1101, the safe change is to drop filedescriptor from the feature list and leave the rest alone. If you'd like to update the PR to that, I'll happily merge it. Otherwise I can do it myself, no problem.

Thanks again!

[xtqqczze]

Ah I see, I saw use-dev-tty had a dependency on filedescriptor in crossterm, so thought I'd try enabling that. But looks like that's completely unnecessary. I've opened #15 and closed this PR.