Skip to content

feat: show operation parameters in access requests - #507

Merged
alongubkin merged 1 commit into
mainfrom
alon/alien-583-visible-access-request-parameters
Aug 27, 2026
Merged

feat: show operation parameters in access requests#507
alongubkin merged 1 commit into
mainfrom
alon/alien-583-visible-access-request-parameters

Conversation

@alongubkin

Copy link
Copy Markdown
Member

Summary

  • preserve exact operation parameters in access-request plans
  • allow the Kubernetes resource schema to retain nested parameter values
  • verify the rendered customer-facing schema

Test plan

  • cargo test -p alien-operator loops::access_requests
  • cargo test -p alien-helm access_request_crd_is_white_labeled_from_the_brand_domain -- --nocapture
  • cargo fmt -p alien-operator -p alien-helm -- --check

@greptile-apps

greptile-apps Bot commented Aug 27, 2026

Copy link
Copy Markdown

Greptile Summary

This PR preserves operation parameters in access-request plans so customers can review the exact commands they are authorizing.

  • Adds a required JSON-object parameter map to each operator access-request command.
  • Extends the generated Kubernetes CRD to retain arbitrary nested parameter values.
  • Verifies the rendered CRD enables unknown-field preservation for command parameters.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The command contract and generated CRD consistently represent parameters as JSON objects, and the schema preserves nested values without conflicting with the typed source.

Important Files Changed

Filename Overview
crates/alien-operator/src/loops/access_requests.rs Adds an object-typed parameter map to the access-request command contract; no in-repository construction or propagation defect was established.
crates/alien-helm/src/generator.rs Extends the access-request CRD with an arbitrary nested-object parameter field and tests that unknown fields are preserved.

Sequence Diagram

sequenceDiagram
    participant CP as Control Plane
    participant OP as Operator
    participant K8s as Kubernetes API
    participant Customer
    CP->>OP: Access request with command params
    OP->>K8s: Materialize access-request CR
    K8s-->>Customer: Display exact command parameters
    Customer->>K8s: Approve for a bounded duration
    OP->>CP: Report approval window
Loading

Reviews (1): Last reviewed commit: "feat: show operation parameters in acces..." | Re-trigger Greptile

@alongubkin
alongubkin merged commit 07cf118 into main Aug 27, 2026
24 checks passed
@alongubkin
alongubkin deleted the alon/alien-583-visible-access-request-parameters branch August 27, 2026 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant