feat: show operation parameters in access requests - #507
Merged
alongubkin merged 1 commit intoAug 27, 2026
Conversation
Greptile SummaryThis PR preserves operation parameters in access-request plans so customers can review the exact commands they are authorizing.
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The command contract and generated CRD consistently represent parameters as JSON objects, and the schema preserves nested values without conflicting with the typed source.
|
| Filename | Overview |
|---|---|
| crates/alien-operator/src/loops/access_requests.rs | Adds an object-typed parameter map to the access-request command contract; no in-repository construction or propagation defect was established. |
| crates/alien-helm/src/generator.rs | Extends the access-request CRD with an arbitrary nested-object parameter field and tests that unknown fields are preserved. |
Sequence Diagram
sequenceDiagram
participant CP as Control Plane
participant OP as Operator
participant K8s as Kubernetes API
participant Customer
CP->>OP: Access request with command params
OP->>K8s: Materialize access-request CR
K8s-->>Customer: Display exact command parameters
Customer->>K8s: Approve for a bounded duration
OP->>CP: Report approval window
Reviews (1): Last reviewed commit: "feat: show operation parameters in acces..." | Re-trigger Greptile
alongubkin
deleted the
alon/alien-583-visible-access-request-parameters
branch
August 27, 2026 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
cargo test -p alien-operator loops::access_requestscargo test -p alien-helm access_request_crd_is_white_labeled_from_the_brand_domain -- --nocapturecargo fmt -p alien-operator -p alien-helm -- --check