fix: probe installed horizond during machine rejoin - #508
Merged
Conversation
Greptile SummaryThis PR fixes machine rejoin connectivity checks for legacy installations by probing the installed
Confidence Score: 5/5The PR appears safe to merge, with the targeted legacy-wrapper bypass covered by a regression test and fallback behavior retained. The new selection is narrowly limited to a service executable named
|
| Filename | Overview |
|---|---|
| crates/alien-deploy-cli/src/commands/join.rs | Routes legacy-wrapper connectivity probes to the sibling horizond binary and adds focused regression coverage; no actionable defect was established. |
Reviews (1): Last reviewed commit: "fix: probe installed horizond during mac..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
horizondbinary directly when checking machine connectivitymachine-entrypointwrappers that do not forward CLI argumentsWhy
Older machine bundles use
machine-entrypointas the service executable. Invoking that wrapper withstatus --jsonstarts another daemon instead of returning status, so rejected credentials are incorrectly classified as an already-joined machine.Testing
cargo nextest run -p alien-deploy-cli --no-fail-fast(135 passed)cargo fmt -p alien-deploy-cli --checkStrict workspace Clippy remains blocked by pre-existing warnings on
main.