Repository navigation
fix(form): an order link lands on the form, framed in the accent line; release 1.15.0 - #24
Merged
Merged
Conversation
…; release 1.15.0 - The form and the email render only in the browser, after the browser has scrolled to #contact on load, so a link from another page (/audit's order links) stopped short of the form by the block's height: 590 px at 1440×900. Once the block is in, the section scrolls into view again - An order link's form is framed like a marked project, the accent line on its left and a tint behind it; a plain visit's form is unchanged
On CI the form mounted while the browser's own smooth scroll to #contact still ran, and an instant scroll mixed with it, landing 12–45 px off. A scroll that follows the page's scroll-behavior replaces the running one and lands on the margin. The test now throttles the CPU to reproduce that order and waits for the scroll to settle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#contact on load, so a link from another page (/audit's order links) stopped short of the form
by the block's height: 590 px at 1440×900. Once the block is in, the section scrolls into view
again, as the page's CSS says: an instant scroll during the browser's own smooth one landed
12–45 px off on CI
behind it; a plain visit's form is unchanged