Fix incorrect unit label for HEA/IPE section properties - #469
Open
Ayberkrk wants to merge 1 commit into
Open
Conversation
The units row in profile.py labels Iy/Wy/Iz/Wz as mm^4/mm^3, but the tabulated values are actually in cm^4/cm^3 (matching standard steel tables). load() already converts them by *1e4/*1e3 assuming a cm source, so only the documentation row was wrong. Fixes anastruct#363
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The units row in
profile.pyfor the HEA and IPE tables labels Iy/Wy/Iz/Wz asmm^4/mm^3, but the tabulated values match standard steel tables incm^4/cm^3(e.g. HEA100 Iy = 349 cm^4).load()already multiplies I by 1e4 and W by 1e3 to convert to mm, which only makes sense if the source values are in cm — confirming the label (not the data or the conversion) was wrong.This is a documentation-only fix to the units row (which is parsed and discarded, so no functional/behavioral change). Verified
HEA[100]andIPE[80]still resolve to the same final mm-based values after the change.Fixes #363