Remove the spotify terminal client - #4
Merged
Merged
Conversation
echo is now the desktop app only. The spotify-tui crate goes, along with the ratatui, crossterm and unicode dependencies, and bare `cargo run` now starts echo-desktop. Updaters in v0.6.7 and earlier replace every binary they find installed and reject an archive that is missing one, so the upgrade archive still carries a `spotify` stub (crates/spotify-stub) that only says the terminal client was removed. The MSI and DMG no longer include it. The updater now replaces only echo-desktop, and at startup deletes the leftover `spotify` binary plus the ~/.local/bin link install.sh made for it, when that link points into this install. install.sh and install.ps1 drop the terminal command and clean up the same leftovers.
Drop the terminal client section, `spotify upgrade`, custom keybindings and the terminal troubleshooting entries. The shortcut list now follows the desktop keymap, and the command list gains :clearhistory, :range, :spotifylogin and :autoupdate, which were missing. Note the removal in release.md.
With the terminal client gone, remove what only it used: - the :redraw and :thumbs commands, the terminal-clear flag and ForceRedraw event, and the ANSI clears written after OAuth - the library_thumbnails and keybindings config fields (old configs still load; the keys drop on the next save) - the Browse library tab and TUI-only UI state fields - the half-block cover sampler and terminal thumbnail sizes - artist navigation wrappers only the TUI called - locale strings only the TUI rendered Comments that described behavior relative to the TUI are reworded for a desktop-only codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
echo becomes the desktop app only.
crates/spotify-tuiand its dependencies (ratatui, crossterm, unicode-*).cargo runnow startsecho-desktop.install.shandinstall.ps1ship only the desktop app.spotifystub (crates/spotify-stub) that only prints a notice.echo-desktop.spotifyand its~/.local/binlink (only when the link points into the install).README.mdandREADME.zh.md: the shortcut list now follows the desktop keymap, and the missing commands are added.assets/echo-tui.png.release.md.:redrawand:thumbscommands, terminal clears, thelibrary_thumbnails/keybindingsconfig, the Browse tab, the half-block sampler, TUI-only state, intents and locale keys.Testing
cargo fmt --check,cargo clippy --workspace --all-targets -D warnings,cargo test --workspace(322 core, 55 desktop) andcargo build --release --workspacepass on Linux.Not verified
install.sh/install.ps1run.Follow-ups
highlight_fgtheme slot.ArtistListSource::Followed.BrowseNode.