fix(material/chips): correct focus management on chip destruction#33329
Merged
Conversation
Un-privatized _redirectDestroyedChipFocus to allow MatChipGrid to override the aggressive focus-stealing behavior with a silent updateActiveItem call, respecting downstream layout stability. Fixes angular#14345
crisbeto
added
action: merge
crisbeto
approved these changes
Jun 16, 2026
Member
crisbeto
pushed a commit
that referenced
this pull request
Jun 16, 2026
…3329) * fix(material/chips): correct focus management on chip destruction Un-privatized _redirectDestroyedChipFocus to allow MatChipGrid to override the aggressive focus-stealing behavior with a silent updateActiveItem call, respecting downstream layout stability. Fixes #14345 * Update chip-grid.ts * Update chip-grid.spec.ts * Update chip.ts (cherry picked from commit e49f127)
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 16, 2026
Comments out a test that started failing after angular#33329.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14345
Description
The Bug:
When a chip is removed from MatChipSet or MatChipGrid, keyboard navigation (like using Shift+Tab or arrow keys) breaks upon subsequent interactions. This happens because the internal FocusKeyManager retains a stale reference to the deleted chip if the focus leaves the chip container (e.g., when the list becomes empty or focus returns to the input box). This stale reference traps keyboard focus or causes it to drop to the document body, failing standard focus order requirements (WCAG 2.1 Success Criterion 2.4.3).
The Fix:
The solution is to preserve standard browser focus redirection while explicitly cleaning up staleReferences when focus exits the chip context. This PR:
Un-privatizes the redirection logic (_lastDestroyedFocusedChipIndex and _redirectDestroyedChipFocus) to protected in the base MatChipSet class.
Allows MatChipGrid to override this behavior, call super._redirectDestroyedChipFocus() to preserve deterministic browser focus moves, and perform a silent cleanup using updateActiveItem(-1) when navigation leaves the chip set.
Why this path?
Deterministic Focus: It relies on the superclass redirection to maintain standard browser focus moves (refocusing the input or next chip) that downstream applications and consuming components expect.
Cleanup without Hijacking: The silent cleanup ensures the FocusKeyManager is reset safely without aggressively forcing a browser focus event or stealing focus from adjacent input fields.
Testing:
Added unit tests to chip-grid.spec.ts asserting that focus redirects correctly to the next chip upon deletion, and that the internal state is safely reset when the last focused chip is destroyed.