Repository navigation
fix(lock-file-maintenance): persist checkout credentials so git-auto-commit can push - #555
Merged
Merged
Conversation
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
prisis
pushed a commit
that referenced
this pull request
Oct 17, 2026
## [25.0.1](v25.0.0...v25.0.1) (2026-10-17) ### Bug Fixes * **lock-file-maintenance:** persist checkout credentials so git-auto-commit can push ([#555](#555)) ([5d2adf5](5d2adf5))
This was referenced Oct 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The reusable
pnpm-lock-file-maintenance.ymlchecks out withpersist-credentials: false, but the comment right above it (and the downstream step) expects the credentials to be persisted:stefanzweifel/git-auto-commit-actionhas no token input — it pushes through the git remote configured by the checkout, so it needs those credentials. Withfalse, the "Commit lock file" step fails:This is exactly what the scheduled Lock File Maintenance job is failing with on consumers (e.g.
anolilab/javascript-style-guide→lock-file / Lock File Maintenance), whenever the run actually produces lockfile changes to commit.Fix
Set
persist-credentials: trueso the push can authenticate — matching the existing comment and the# zizmor: ignore[artipacked]that already anticipated persistence.Rollout note
Consumers pin this reusable workflow by ref (e.g.
@fb7a881…# v24.2.0,@2bd348c…# v21.0.5,@aa162a9…# v20.2.5), so they will pick the fix up once this is released and their ref is bumped (Renovate already raisesanolilab/workflowsbumps).Summary by CodeRabbit