Skip to content

fix(lock-file-maintenance): persist checkout credentials so git-auto-commit can push - #555

Merged
prisis merged 1 commit into
mainfrom
fix/lock-file-maintenance-persist-credentials
Oct 17, 2026
Merged

prisis merged 1 commit into
mainfrom
fix/lock-file-maintenance-persist-credentials

Conversation

@prisis

@prisis prisis commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Problem

The reusable pnpm-lock-file-maintenance.yml checks out with persist-credentials: false, but the comment right above it (and the downstream step) expects the credentials to be persisted:

# Persist credentials so the downstream git-auto-commit-action can push
# using the explicitly-passed token.
- uses: "actions/checkout@... "
  with:
      token: "${{ secrets.github-token || secrets.GITHUB_TOKEN }}"
      persist-credentials: false   # <-- contradicts the comment

stefanzweifel/git-auto-commit-action has no token input — it pushes through the git remote configured by the checkout, so it needs those credentials. With false, the "Commit lock file" step fails:

fatal: could not read Username for 'https://github.com': No such device or address
Error: Invalid status code: 128

This is exactly what the scheduled Lock File Maintenance job is failing with on consumers (e.g. anolilab/javascript-style-guide → lock-file / Lock File Maintenance), whenever the run actually produces lockfile changes to commit.

Fix

Set persist-credentials: true so the push can authenticate — matching the existing comment and the # zizmor: ignore[artipacked] that already anticipated persistence.

Rollout note

Consumers pin this reusable workflow by ref (e.g. @fb7a881… # v24.2.0, @2bd348c… # v21.0.5, @aa162a9… # v20.2.5), so they will pick the fix up once this is released and their ref is bumped (Renovate already raises anolilab/workflows bumps).

Summary by CodeRabbit

  • Chores
    • Updated repository automation so maintenance tasks can retain authentication during checkout. No changes to the app’s user-facing features or behavior.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8e6b3db3-d42e-4f33-b15e-ebcb22207b2f
📥 Commits

Reviewing files that changed from the base of the PR and between 263944e and f0f5002.

📒 Files selected for processing: 1
  • .github/workflows/pnpm-lock-file-maintenance.yml
+--------------------------------------------+
| Forcing bugs to surrender unconditionally. |
+--------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@prisis
prisis merged commit 5d2adf5 into main Oct 17, 2026
18 of 19 checks passed
@prisis
prisis deleted the fix/lock-file-maintenance-persist-credentials branch October 17, 2026 08:46
prisis pushed a commit that referenced this pull request Oct 17, 2026
## [25.0.1](v25.0.0...v25.0.1) (2026-10-17)

### Bug Fixes

* **lock-file-maintenance:** persist checkout credentials so git-auto-commit can push ([#555](#555)) ([5d2adf5](5d2adf5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant