Skip to content

Cleanup - #270

Merged
anttiharju merged 6 commits into
mainfrom
cleanup
Sep 26, 2026
Merged

anttiharju merged 6 commits into
mainfrom
cleanup

Conversation

@anttiharju

Copy link
Copy Markdown
Owner

No description provided.

@anttiharju anttiharju added the patch-release Generate a new patch release. label Sep 26, 2026
@anttiharju

Copy link
Copy Markdown
Owner Author

I was worried that the binary checksum verification would be a waste of time

but it now even protects against cache poisoning! Fascinating!

2s
Run anttiharju/find-changes-action@v0
Check cache
0s
Generate target triple
0s
Cache
1s
Verify binary
0s
Run "$GITHUB_ACTION_PATH/scripts/verify.sh"
  sha256sum: WARNING: 1 computed checksum did NOT match
  /__w/_temp/anttiharju/compare-changes/0.12.22/compare-changes: FAILED
  Error: Process completed with exit code 1.

the "cache poisoning" was me injecting a locally built binary in the job that got (wrongly) cached as the true one. That's why container job passed and validate failed. Fascinating.

@anttiharju
anttiharju marked this pull request as ready for review September 26, 2026 22:06
@anttiharju
anttiharju merged commit 4d1d40a into main Sep 26, 2026
8 checks passed
@anttiharju
anttiharju deleted the cleanup branch September 26, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch-release Generate a new patch release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant