Repository navigation
Bump version 1.4.1 Button Order shows icons only, names in tooltips - #425
Merged
Merged
Conversation
On a phone the drag handle and the two toggles left the name a few letters a line, and an app's own action is named by its tooltip, so its Markdown appeared raw. Each row now shows the icon, as on the AppBar, with the name in a MarkdownTooltip on the icon (not the drag handle).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In Settings → Button Order on a phone, the drag handle and the visibility
and overflow toggles left the button name a few letters a line ("The / me
/ Tog / gle"). An app's own AppBar action is named by its tooltip, so its
Markdown appeared raw (e.g. innerpod's
**Session Bell**...).Each row now shows the button's icon alone, as on the AppBar itself, with
its name in a
MarkdownTooltipon the icon. The tooltip is on the icon,not the drag handle, so it is not the live tooltip during a drag.
Testing
make prepclean;flutter testpasses (109, including 2 new intest/solid_preferences_button_order_test.dart: rows show icons notnames, and each icon carries its name as a tooltip).