Repository navigation
feat: make a session something to work in, and say it in Korean - #70
Merged
Merged
Conversation
…se, and put Prism's windows away
…r own mouse moves
…, and drop the drawer
…the picture arrives at
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seventy-six commits that have never been through CI: the branch was started for Korean and
became where everything went. This is the one PR that puts them on
develop, mostly so theWindows and Linux jobs finally compile code that no local check covers —
prism-tauriisexcluded from
lint:crossentirely, andprism-streamis excluded on the Windows target, sod3d11.rs, the shell's platform code and this branch'sSetThreadExecutionStatehave beenwritten blind.
What is in it
Korean, and the interface around it. The English sentence is the key, so an untranslated
string comes out in English rather than as a name nobody wrote. Settings grew a card per
concern, and one button stopped doing two things.
Files between the two machines. A channel of their own on the wire, and — new here — a
window of their own: what is moving, what the far machine offers, what has arrived. The shell
can now ask a running stream for something, which it could not before: the pipe was closed
after
Startbecause there was no second message, and that is why files were only everoffered from inside the stream window.
The session, ended properly at both ends. A goodbye the host sends; a host that now gives
up on a client that has stopped answering rather than only on one whose port refused; a shell
that ends a stream it can no longer read instead of leaving it running and showing
connectingforever.Four things found by reading rather than by failing. The replay window cleared one counter
too early, so a packet already accepted could be replayed. The parity path was not bounded the
way the video path is. An ack reported a frame at the window's far edge as lost. The settings
and the session history were written with
fs::write, whichstore.rsexists to avoid — andstore.rs's own module doc names both files.The relay, which had never carried a byte. A region's security rule matched on the source
port, so nothing reached the relay port at all; the docs said one port where the code needs
two. Both ends now fall through to the relay for any failure rather than only a timeout, and
the client says which near path failed rather than only that the relay did not open.
The stream window. Full screen brings the title bar back at the top edge instead of a
drawer of our own. The statistics are behind a control and off by default. The shrink control
is a step down — out of full screen, then into the Dock. The picture's size is on the panel,
which is what answered "why does this look soft": it arrives smaller than the window and is
stretched.
Both screens stay awake while a session runs, which is new, and the pointer follows a host
whose screen changes size mid-session, which it did not.
What this does not do
mainis still at PR #3 anddeploy.ymlsendsmainto production, so this reaches stagingand nothing else. Production still runs the rendezvous and accounts from that commit.