Show portcount - #8
Open
rajpratik71 wants to merge 10 commits into
Open
Conversation
* this is just a POC. * It works until you start scrolling, then it turns into a shit show. * Need to figure some logic for when to do a portscan-- right now it's done when the item rolls into view in the listview. This is smart in that you're not scanning things until they show up on screen. This is dumb in that if you scroll, a ton of portscans are launched. * It's also dumb in that as new items pop into the listview, the order is no longer preserved and the wrong item gets changed (Reciever needs a better way of remembering which item it was scanning than just the position, because that changes as new items are listed. Using the view doesn't work either as thyey're recycled on scrolling. I'm sure I just need to think a second and the answer will be obvious. * No Preferences support.. it always scrolls. * It probably also crashes easily. I didn't test much.
There are still bugs with the feature, but here are the label bits anyway
Eventually will want to do complex animations, but for now, I think the dissolves make it feel more like a single program rather than multiple activities sliding in and out. Makes me less dizzy too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.