fix(proxy-rewrite): transform header names to lower case before removal - #13816
Open
bearn01d wants to merge 1 commit into
Open
fix(proxy-rewrite): transform header names to lower case before removal#13816bearn01d wants to merge 1 commit into
bearn01d wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In line with the specification of HTTP/2, APISIX apparently processes all headers in lower case. For this reason, entries of the
headers.removesection inproxy-rewritethat contain capital letters are ignored, also in cases where the client sends them with capital letters. This may lead to unintended data leaks.This PR transforms headers in
headers.removeto lower case to ensure removal of all headers intended to be removed.The docs seem to intend the behavior this PR establishes.
Checklist