Reject oversized binary view values - #947
Open
efegokdemir wants to merge 1 commit into
Open
efegokdemir wants to merge 1 commit into
efegokdemir wants to merge 1 commit into
Conversation
Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
=======================================
Coverage 78.19% 78.19%
=======================================
Files 106 106
Lines 16843 16845 +2
Branches 1985 1986 +1
=======================================
+ Hits 13170 13172 +2
Misses 2439 2439
Partials 1234 1234 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
INT32_MAXbefore narrowing the length into the Arrow binary-view representation.Fixes #938
Testing
cmake -S . -B /tmp/arrow-nanoarrow-build-938 -DNANOARROW_BUILD_TESTS=ON— passed.cmake --build /tmp/arrow-nanoarrow-build-938 --parallel 2— passed.ctest --test-dir /tmp/arrow-nanoarrow-build-938 --output-on-failure— passed (287/287; 3 thread-safety tests skipped by project configuration).git diff --check— passed.AI assistance was used during implementation; the submitted changes were reviewed and validated against the issue and the project test suite.