Skip to content

fix(cmake): allow linking a shared flatccrt #949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
daeho-ro wants to merge 1 commit into
base: main
Choose a base branch
from
+26 −9
Open

fix(cmake): allow linking a shared flatccrt #949

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 26 additions & 9 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,25 +218,42 @@ if(NANOARROW_IPC)
ARCHIVE DESTINATION ${CMAKE_INSTALL_LIBDIR})

elseif(NOT NANOARROW_FLATCC_ROOT_DIR)
add_library(flatccrt STATIC IMPORTED)
# Prefer a static flatccrt but fall back to a shared one
find_library(NANOARROW_FLATCC_LIBRARY
NAMES "${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt${CMAKE_STATIC_LIBRARY_SUFFIX}"
flatccrt
PATHS "${NANOARROW_FLATCC_LIB_DIR}"
NO_DEFAULT_PATH REQUIRED)
add_library(flatccrt UNKNOWN IMPORTED)
set_target_properties(flatccrt
PROPERTIES IMPORTED_LOCATION
"${NANOARROW_FLATCC_LIB_DIR}/${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt${CMAKE_STATIC_LIBRARY_SUFFIX}"
PROPERTIES IMPORTED_LOCATION "${NANOARROW_FLATCC_LIBRARY}"
INTERFACE_INCLUDE_DIRECTORIES
"${NANOARROW_FLATCC_INCLUDE_DIR}")

elseif(NOT NANOARROW_FLATCC_INCLUDE_DIR)
set(NANOARROW_FLATCC_INCLUDE_DIR "${NANOARROW_FLATCC_ROOT_DIR}/include")
add_library(flatccrt STATIC IMPORTED)
# Prefer a static flatccrt but fall back to a shared one
find_library(NANOARROW_FLATCC_LIBRARY
NAMES "${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt${CMAKE_STATIC_LIBRARY_SUFFIX}"
flatccrt
PATHS "${NANOARROW_FLATCC_ROOT_DIR}/lib"
NO_DEFAULT_PATH REQUIRED)
find_library(NANOARROW_FLATCC_LIBRARY_DEBUG
NAMES "${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt_d${CMAKE_STATIC_LIBRARY_SUFFIX}"
flatccrt_d
PATHS "${NANOARROW_FLATCC_ROOT_DIR}/debug/lib"
NO_DEFAULT_PATH)
add_library(flatccrt UNKNOWN IMPORTED)
set_target_properties(flatccrt
PROPERTIES IMPORTED_LOCATION
"${NANOARROW_FLATCC_ROOT_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt${CMAKE_STATIC_LIBRARY_SUFFIX}"
IMPORTED_LOCATION_DEBUG
"${NANOARROW_FLATCC_ROOT_DIR}/debug/lib/${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt_d${CMAKE_STATIC_LIBRARY_SUFFIX}"
PROPERTIES IMPORTED_LOCATION "${NANOARROW_FLATCC_LIBRARY}"
IMPORTED_LOCATION_RELEASE
"${NANOARROW_FLATCC_ROOT_DIR}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}flatccrt${CMAKE_STATIC_LIBRARY_SUFFIX}"
"${NANOARROW_FLATCC_LIBRARY}"
INTERFACE_INCLUDE_DIRECTORIES
"${NANOARROW_FLATCC_INCLUDE_DIR}")
if(NANOARROW_FLATCC_LIBRARY_DEBUG)
set_target_properties(flatccrt PROPERTIES IMPORTED_LOCATION_DEBUG
"${NANOARROW_FLATCC_LIBRARY_DEBUG}")
endif()
endif()

if(NANOARROW_IPC_WITH_ZSTD)
Expand Down
Loading