Allow for serialization of Parquet Page Index via custom PageIndexProvider - #11031
Open
etseidl wants to merge 2 commits into
Open
Allow for serialization of Parquet Page Index via custom PageIndexProvider#11031etseidl wants to merge 2 commits into
PageIndexProvider#11031etseidl wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
ParquetMetaDataWritersilently omits page indexes from customPageIndexProviders #11030.Rationale for this change
See issue, but allow for serialization of the page indexes through the
PageIndexProviderAPI.What changes are included in this PR?
Changes
ThriftMetadataWriterto operate through thePageIndexProviderAPI rather than using individual column and offset index vectors. Removes some now unnecessarypub(crate)functions.Are these changes tested?
Yes
Are there any user-facing changes?
All page indexes will now serialize, but no changes to the public API