chore: Fix duplicated word typos in comments and docs - #11034
Open
geographybuff wants to merge 2 commits into
Open
chore: Fix duplicated word typos in comments and docs#11034geographybuff wants to merge 2 commits into
geographybuff wants to merge 2 commits into
Conversation
Removes thirteen accidentally doubled words across eleven Rust files and one Markdown file: "run-encoded encoded", "and and an offset", "typed typed on", "must must enable", "2. the the null count", "Note this this", "are used used", "of the the column metadata", "to the the histogram's", "to be be calculated", "required required for", "to pass to to" and "from from an iterator". Comment and prose text only, with no code changes. The `PageHeader` case is a transcription slip rather than a faithful copy: upstream parquet-format's parquet.thrift reads "to be calculated". These survive CI because the typos checker matches misspelled words and does not detect a correctly spelled word repeated twice in a row. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Jefffrey
reviewed
Sep 9, 2026
Jefffrey
left a comment
Contributor
There was a problem hiding this comment.
do we need such a verbose PR body for these simple fixes 😅
Co-authored-by: Jeffrey Vo <jeffrey.vo.australia@gmail.com>
Jefffrey
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A — small standalone cleanup, following the precedent of recent comment-typo PRs merged without a linked issue:
chore: Fix typos(47 files, +108/-107)chore: fix typos in code comments(11 files, +16/-16)chore: fix typo in release email templateRationale for this change
Several comments contain accidentally doubled words —
run-encoded encoded data,and and an offset,typed typed on,are used used. Most are rustdoc on public items, so they render on docs.rs.These survive automated checking because the CI spell check (
.github/ci/scripts/typos_check.sh, thetyposcrate) matches misspelled words and does not detect a correctly spelled word repeated twice in a row.typos --config typos.tomlpasses on both the unmodified tree and this branch.One case is more than cosmetic. In
parquet/src/file/metadata/thrift/mod.rs, thePageHeaderdoc comment is a transcription of the Parquet Thrift IDL, and readsto be be calculated as follows. Upstreamparquet-format'sparquet.thriftreadsto be calculated, so this is a transcription slip and the fix restores agreement with the spec.Found by searching the tree for
\b(\w+)\s+\1\brestricted to comment and prose lines. The remaining matches are ASCII-art layout diagrams inlist_array.rs/list_view_array.rs(Logical Logicalcolumn headings) and correct English like100-row row group; those are left alone.What changes are included in this PR?
Removes 13 doubled words across 11 Rust files and 1 Markdown file. Comment and prose text only — no code changes.
arrow-buffer/src/lib.rsRun-ends used in run-encoded encoded dataarrow-buffer/src/util/bit_chunk_iterator.rsand and an offset and length in bitsarrow-array/src/array/run_array.rsA RunArray typed typed on its child values arrayarrow-data/src/data.rs2. the the null count is correctarrow-data/src/transform/mod.rsNote this this is not stored in _MutableArrayDataparquet/src/file/properties.rsdefault values for ndv and fpp value are used usedparquet/src/file/metadata/mod.rs(x2)Takes ownership of the the column metadata;Returns a reference to the the histogram's valuesparquet/src/file/metadata/thrift/mod.rsCRC checksum for the page, to be be calculatedparquet/src/arrow/mod.rsthe AES encryption keys required required for decryptingparquet/src/arrow/arrow_reader/mod.rsmaximum size of value to pass to to value generatorparquet/src/arrow/arrow_reader/statistics.rsextracting i128 values from from an iteratorparquet_derive/README.mdYou must must enable the chrono featureAre these changes tested?
No new tests — the change is confined to comments and prose, so there is no behaviour to cover.
Checks run locally on Linux x86_64 with the pinned 1.98.1 toolchain:
typos --config typos.toml(v1.37.0, the version pinned indev.yml) — passcargo fmt --all --check— passcargo test --doc -p arrow-buffer -p arrow-array -p arrow-data -p parquet --all-features— pass, 376 doctests, 0 failed (arrow-array 206, parquet 96, arrow-buffer 60, arrow-data 14)This first failed with 5 errors, all of them
PARQUET_TEST_DATA is undefinedfrom an uninitialisedparquet-testingsubmodule rather than anything in this PR. The numbers above are from the re-run aftergit submodule update --init.parquet_derive/README.mdis outside the prettier glob indev.yml({arrow,arrow-flight,dev,arrow-integration-testing,parquet}/**/*.md), so the docs formatting job is unaffected.I did not run the full test suite. One edited line sits inside a rustdoc example (
parquet/src/arrow/mod.rs, the encryption example), and that doctest is covered by the run above; every other edited line is an ordinary comment.Are there any user-facing changes?
No API or behaviour changes. The rendered rustdoc is corrected for
RunEndBuffer,UnalignedBitChunk::new,Int64RunArray,ArrayData,WriterProperties,ColumnChunkMetaDataBuilder::take_column_metadata,Histogram::values,PageHeader, and twoparquet::arrowreader items.AI disclosure
This contribution was AI-assisted. Claude Code (Claude Opus 5) performed the tree-wide doubled-word search, made the 13 line edits, checked the
PageHeadercomment against upstreamparquet-format, and ran every check listed above. The check commands were executed by the AI and have not been independently re-run by hand.