feat(arrow-cast): move map cast tests to integration suite - #11041
Open
codewarnab wants to merge 2 commits into
Open
feat(arrow-cast): move map cast tests to integration suite#11041codewarnab wants to merge 2 commits into
codewarnab wants to merge 2 commits into
Conversation
14 tasks
sdf-jkl
approved these changes
Sep 9, 2026
sdf-jkl
left a comment
Member
There was a problem hiding this comment.
Thanks @codewarnab LGTM.
@Jefffrey please take a look at the proposed split and lmk if you agree with the direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #11033.
Rationale for this change
The public-behavior cast tests in
arrow-cast/src/cast/mod.rsare being moved into a crate-level integration test suite so individual cast families are easier to locate and maintain. This is the map-test slice of that work.What changes are included in this PR?
arrow-castcastintegration-test target.arrow-cast/tests/cast/.cast/mod.rstest module totests/cast/map.rs.Are these changes tested?
cargo test -p arrow-cast --test castcargo fmt --all -- --checkA targeted Clippy run is blocked by existing
arrow-datawarnings under the locally installed Clippy version.Are there any user-facing changes?
No. This is a test-organization-only change.
AI usage disclosure
OpenAI Codex assisted with the mechanical test extraction. I reviewed the resulting changes and verified the targeted tests locally.