Fix Variant reads of wide physical decimals - #11072
Draft
peterxcli wants to merge 1 commit into
Draft
Conversation
github-actions
Bot
added
parquet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #11067.
What changes are included in this PR?
Normalize Decimal256 inputs with Variant-compatible precision and scale to the appropriate decimal width. Use strict casts and check physical decimal narrowing so overflow returns an error and null payloads are skipped safely.
Are these changes tested?
Regression coverage includes Parquet files with 17- and 32-byte decimal columns, signed values, precision limits, overflow, nulls, and slices. Arrow cast and Variant tests, the Parquet regression, formatting, and Clippy pass with Rust 1.98.1.
Are there any user-facing changes?
Variant readers accept wide physical decimals with precision at most 38. Higher precision remains unsupported.
Implementation and tests developed with Codex assistance.