ARTEMIS-6116 Fix tests for windows OS#6513
Open
GChuf wants to merge 10 commits into
Open
Conversation
jbertram
reviewed
Jun 19, 2026
| producer.applyProperties(mockMessage); | ||
|
|
||
| assertEquals("Unable to set property: myKey. Did not recognize type: myType. Supported types are: boolean, int, long, byte, short, float, double, string.\n", context.getStderr()); | ||
| assertEquals("Unable to set property: myKey. Did not recognize type: myType. Supported types are: boolean, int, long, byte, short, float, double, string.\n", context.getStderr().replace("\r\n", "\n")); |
Contributor
There was a problem hiding this comment.
This seems like a good place to use System.lineSeparator().
jbertram
reviewed
Jun 19, 2026
| -Djava.library.path="${activemq.basedir}/target/bin/lib/linux-x86_64:${activemq.basedir}/target/bin/lib/linux-i686" | ||
| -Djgroups.bind_addr=localhost | ||
| -Djava.net.preferIPv4Stack=true | ||
| -Dbasedir=${basedir} |
Contributor
There was a problem hiding this comment.
Can you elaborate on the problem this is causing? Several tests use System.getProperty("basedir") so I would expect removing this line would cause such tests problems.
Contributor
Author
There was a problem hiding this comment.
This one resolves the following warning:
Warning: The system property basedir is configured twice! The property appears in <argLine/> and any of <systemPropertyVariables/>, <systemProperties/> or user property.
If I remember correctly, it was producing some kind of error on windows. Maybe I should have added more info in the commit message.
Ensures that the "basedir" system property is only configured once
Reduce network timeout checked because windows reports lower timeouts
GChuf
force-pushed
the
ARTEMIS-6116
branch
3 times, most recently
from
68dbc08 to
cd991dc
Compare
Fixes issues related to backslashes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some errors, not all of them.
Submitting this "work in progress" before I forget I was doing work here.